• 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
ChordPro: '#' comment not working as expected
#1
Lines starting with # are commented out and should be made invisible.
I came across an example where this is not the case: if the line that shall be commented out contains keywords like "title:" or "artist:" the comment is not working, see attachments.


Attached Files Thumbnail(s)
       
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 2004
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#2
I'll have to improve the comment detection with # so that it disregards those lines while processing things like title: and artist:.

Thanks,
Mike
Reply
#3
Do you have a reason not to discard # lines immedeately after reading?
Johan
www.johanvromans.nlwww.hetgeluidvanseptember.nlwww.howsagoin.nl
Samsung Galaxy Note S7FE (T733) 12.4", Android 11.0, AirTurn Duo & Digit.
Samsung Galaxy Note S4 (T830) 10.5", Android 10.0 (backup).
Samsung A3 (A320FL), Android 8.0.0 (emergency).
Reply
#4
I discovered the behaviour after downloding that song and kept it willingly to report the issue. I even added the line with #{Title: myself to cross-check.
But yes, you are right, usually I just would have deleted the lines that annoy me.
On the other hand, sometimes it makes sense to keep lines that should not be displayed for later reference.
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 2004
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#5
I'll change it to discard any line starting with a #, as the chord pro spec describes.
Reply
#6
@itsme: Sorry for the confusion. My remark wat meant for Mike...
Johan
www.johanvromans.nlwww.hetgeluidvanseptember.nlwww.howsagoin.nl
Samsung Galaxy Note S7FE (T733) 12.4", Android 11.0, AirTurn Duo & Digit.
Samsung Galaxy Note S4 (T830) 10.5", Android 10.0 (backup).
Samsung A3 (A320FL), Android 8.0.0 (emergency).
Reply


Digg   Delicious   Reddit   Facebook   Twitter   StumbleUpon  


Users browsing this thread:
2 Guest(s)


  Theme © 2014 iAndrew  
Powered By MyBB, © 2002-2021 MyBB Group.