• 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
ChordGrid: don't transpose comment columns
#1
A ChordGrid has two columns left and right of the grid. They are intended to contain comment that shall not be transposed.
   
Attachment ThoseWereTheDays_Gm_SHe_ABC.pdf shows the same song created by the ChordPro reference implementation.


Attached Files
.pdf   ThoseWereTheDays_Gm_SHe_ABC.pdf (Size: 380.85 KB / Downloads: 8)
.pro   ThoseWereTheDays_SHe_ABC.pro (Size: 1.11 KB / Downloads: 7)
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 22H2 - Huawei Media Pad T5, Android 8.0 - Boox Tab Ultra C, Android 11
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#2
Oh interesting - I didn't know the text in the margins shouldn't be transposed. Easy enough change I think.

Thanks,
Mike
Reply
#3
The margins are like comments. 'A' is a letter A, [A] a (transposable) chord name A.
Johan
johanvromans.nl — hetgeluidvanseptember.nl — mojore.nl -- howsagoin.nl
Samsung Galaxy Note S7FE (T733) 12.4", Android 13.0, AirTurn Duo & Digit (Gigs).
Samsung Galaxy Note S4 (T830) 10.5", Android 10.0 (maintenance and backup).
Samsung A3 (A320FL), Android 8.0.0 (emergency).
Reply
#4
Thanks Johan for additional clarification
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 22H2 - Huawei Media Pad T5, Android 8.0 - Boox Tab Ultra C, Android 11
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#5
Sciurius reported a difference between MobileSheets, see https://groups.io/g/ChordPro/topic/111384559:

The margin chords are treated as comments. The chords are rendered with the comment font. This is intentional, so these look the same:
Code:
{comment: From A to [B] to C}
{comment: From A to B to C}
(except that the 1st B may be transposed).
MSPro renders these like chords, using the chord font.

I prefer the way MobileSheets renders it and would accept if it is different. So the comment "(B) in E" should look the same as a normal comment and in the first column of the grid.
   


Attached Files
.pro   DreamALittleDream.pro (Size: 1.23 KB / Downloads: 0)
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 22H2 - Huawei Media Pad T5, Android 8.0 - Boox Tab Ultra C, Android 11
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#6
So it's a little unclear to me - do you want me to change it so that the comments are rendered using the same setting as a {comment:}, or are you saying you don't want me to change anything? Also, should I use the grid text size setting for the comments or switch that to use the lyrics text size, which is normally what would be used for a comment? My current plan is to switch to using the same font that I would use for a {comment} but modify the text size to match that of the grid text size setting so it matches the other parts of the chord grid.

Thanks,
Mike
Reply
#7
Sorry if I was unclear.

- using the same font that I would use for a {comment}
That's how Sciurius renders chords in comments in the reference implementation - so this is the most compatible way. That's what I'm usually asking for. 
In case of chords in comments I would prefer to keep it as you currently do it in {comment sections: render chords like in chords & lyrics sections. I also posted in https://groups.io/g/ChordPro/topic/111384559 that this would be my preferred style.

- should I use the grid text size setting for the comments
Definitely yes. The font size of comments within grids should be the same as the chords.

Here's how I personally would prefer it to look, transposed from A to G, source attached
   

But I'm still discussing the topic with Sciurius in the post mentioned above


Attached Files
.pro   ChordsInComments.pro (Size: 478 bytes / Downloads: 1)
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 22H2 - Huawei Media Pad T5, Android 8.0 - Boox Tab Ultra C, Android 11
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#8
Rendering the chords in comments separately from the rest of the text in chord grid margins is definitely going to lead to some difficulty. I also don't support pango markup in comments in chord grids at the moment, so that's going to require even more changes. Then I would have to add more code to break up labels in the margins into parts (regular text + chords) and render each of those separately. So I would potentially need to change quite a bit of code.

Mike
Reply
#9
I bear with you... These are the hoops I need to jump through almost daily Smile
Johan
johanvromans.nl — hetgeluidvanseptember.nl — mojore.nl -- howsagoin.nl
Samsung Galaxy Note S7FE (T733) 12.4", Android 13.0, AirTurn Duo & Digit (Gigs).
Samsung Galaxy Note S4 (T830) 10.5", Android 10.0 (maintenance and backup).
Samsung A3 (A320FL), Android 8.0.0 (emergency).
Reply
#10
I've modified the code to at least utilize the pango markup syntax in the grid comments, and they are rendered with the same italic font as comments. I won't be able to tackle rendering chords differently for a while, as I really need to start focusing on other requests.

Mike
Reply
#11
Thank you, Mike. I fully agree, that there are more important topics than the formatting of chords in comments.
Could you please make a version available that contains the latest fixes? Thanks.
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 22H2 - Huawei Media Pad T5, Android 8.0 - Boox Tab Ultra C, Android 11
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#12
I'm working on it - just making the same changes on Windows and iOS so I can get the update released.

Mike
Reply




Users browsing this thread:
1 Guest(s)


  Theme © 2014 iAndrew  
Powered By MyBB, © 2002-2025 MyBB Group.