• 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
ChordPro directives not recognized without colon
#1
As many ChordPro users I have the habit of using terminating directive keywords with a colon, e.g.

Code:
{title: My Song}

However, the colon has always been optional according to the ChordPro specification.

I can live with MSPro requiring the colon, as it is just nicer/better, but users importing arbitrary ChordPro files from the internet may occasionally get a surprise...
For example, you'll quickly notice that the song title is not picked up, but you'll probably not going to notice that meta data like composer, key, time, tempo is silently ignored.
Johan
johanvromans.nl — hetgeluidvanseptember.nl — mojore.nl -- howsagoin.nl
Samsung Galaxy Note S7FE (T733) 12.4", Android 13.0, AirTurn Duo & Digit (Gigs).
Samsung Galaxy Note S4 (T830) 10.5", Android 10.0 (maintenance and backup).
Samsung A3 (A320FL), Android 8.0.0 (emergency).
Reply
#2
I didn't know by now that the colons are optional and never came across ChordPro files without them.
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 22H2 - Huawei Media Pad T5, Android 8.0 - Boox Tab Ultra C, Android 11
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#3
I was actually handling this correctly for about half of the commands (the ones not related to metadata). I've updated the code to use the same approach in all places so it should work now for all chord pro commands.

Thanks,
Mike
Reply




Users browsing this thread:
1 Guest(s)


  Theme © 2014 iAndrew  
Powered By MyBB, © 2002-2024 MyBB Group.