• 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
ChordPro Formatted Sheet
#1
Thanks for adding the code to allow for a bar line | to be part of the chord line but I noticed that there is some space in the lyrics where the bar line is and also there is an extra space after the bar line before the chord name.

Example 1:
[|][C]This is the [|][F]lyrics line 1 and [|][Dm]this [G]is line [|][C]two

Result 1:
| C              | F                | Dm       G         | C 
  This is the    lyrics line 1    and this is line     two

If I take out the space before the bar line | then a dash - is added to the lyrics line but there is no extra space after the bar line | before the chord name.

Example 2:
[|][C]This is the[|][F]lyrics line 1 and[|][Dm]this [G]is line[|][C]two

Result 2:
| C            |F              |Dm        G     |C
  This is the-lyrics line 1-and this is line-two

Is it possible to have this corrected.

Thanks.
Reply
#2
What exactly has been changed regarding [|] in 3.9.x ? I used it all the time, in many previous versions of MobileSheets and it worked sufficiently well.
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 22H2 - Huawei Media Pad T5, Android 8.0 - Boox Tab Ultra C, Android 11
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#3
Very little code was changed outside of adding support for chord grids and abc sections. I certainly didn't make any changes specifically regarding [|]. I did change some of the chord processing to support lowercase chords, but that wouldn't have any impact on something that isn't a chord like [|].

With your specific test, in the first example, the [|] and [F] are side-by-side, so the code is going to try to line up the [|] and the [F] with the 'l' in lyrics. The space that is being inserted is expected to make room for both characters, although it might be a little larger than expected (I'll have to check this, but it's the same on Android). In the second example, you have left no space at all between the lyrics, so MobileSheets sees that the [|] should be between 'e' and 'l' in thelyrics (it will be joined because there is no space) and [F] should also be between 'e' and 'l'. So it tries to jam them in the middle of the word, but '|' and 'F' together is wider than a single character, so it inserts a dash to space things out to make room for the chords so that things line up properly. I don't think something is quite right with the measurement for inserting the dash/line though, because if you changed it to [Longword][|] just as an example, it will make the line far longer than it needs to be. This works perfectly fine on Android, so it appears to be a Windows-only issue.

I just tested with 3.8.43, and it renders identically to 3.9.3. So nothing has changed in this regard.

Mike
Reply




Users browsing this thread:
1 Guest(s)


  Theme © 2014 iAndrew  
Powered By MyBB, © 2002-2024 MyBB Group.